For some context, I'm writing an allocator that takes in a base allocator as a template type, and does nothing but forward the allocate()
and deallocate()
calls to the underlying allocator member. Creating std::vector
s with this custom allocator works fine. I tried writing a make_shared
wrapper that will use dummy_allocator<T, std::allocator<T>>
by default but it wasn't successful. Here is a reproducible example:
#include <memory>
namespace test {
template<typename T, typename base_allocator=std::allocator<T>>
class dummy_allocator {
public:
typedef typename std::allocator_traits<base_allocator>::size_type size_type;
typedef typename std::allocator_traits<base_allocator>::difference_type difference_type;
typedef typename std::allocator_traits<base_allocator>::pointer pointer;
typedef typename std::allocator_traits<base_allocator>::const_pointer const_pointer;
typedef typename std::allocator_traits<base_allocator>::value_type value_type;
template<class U>
struct rebind {
typedef dummy_allocator<U,
typename std::allocator_traits<base_allocator>::template rebind_alloc<U>> other;
};
template<typename... Args>
dummy_allocator(Args &&... args) noexcept : alloc(std::forward<Args>(args)...) {}
dummy_allocator(const dummy_allocator& a) = default;
[[nodiscard]] T *allocate(std::size_t n) {
T *p = alloc.allocate(n);
return p;
}
void deallocate(T *p, std::size_t size) noexcept {
alloc.deallocate(p, size);
}
private:
base_allocator alloc;
};
/// Allocate using a wrapped version of passed in allocator
template <typename T, typename Alloc, typename... Args>
std::shared_ptr<T> allocate_shared(const Alloc& alloc, Args&&... args) {
auto dummy_alloc = dummy_allocator<T, Alloc>(alloc);
return std::allocate_shared<T>(dummy_alloc, std::forward<Args>(args)...);
}
/// Create a shared pointer from a default stl allocator wrapped in profile allocator.
template <typename T, typename... Args>
std::shared_ptr<T> make_shared(Args&&... args) {
return test::allocate_shared<T>(std::allocator<T>(), std::forward<Args>(args)...);
}
} // namespace test
int main() {
auto ptr = test::make_shared<double>();
return 0;
}
When I ran the above code, the compiler generated some bizarre template substitution failure errors:
/usr/include/c++/10.1.0/bits/shared_ptr_base.h:679:43: required from ‘std::__shared_count<_Lp>::__shared_count(_Tp*&, std::_Sp_alloc_shared_tag<_Alloc>, _Args&& ...) [with _Tp = double; _Alloc = test::dummy_allocator<double, std::allocator<double> >; _Args = {}; __gnu_cxx::_Lock_policy _Lp = __gnu_cxx::_S_atomic]’
/usr/include/c++/10.1.0/bits/shared_ptr_base.h:1371:71: required from ‘std::__shared_ptr<_Tp, _Lp>::__shared_ptr(std::_Sp_alloc_shared_tag<_Tp>, _Args&& ...) [with _Alloc = test::dummy_allocator<double, std::allocator<double> >; _Args = {}; _Tp = double; __gnu_cxx::_Lock_policy _Lp = __gnu_cxx::_S_atomic]’
/usr/include/c++/10.1.0/bits/shared_ptr.h:408:59: required from ‘std::shared_ptr<_Tp>::shared_ptr(std::_Sp_alloc_shared_tag<_Tp>, _Args&& ...) [with _Alloc = test::dummy_allocator<double, std::allocator<double> >; _Args = {}; _Tp = double]’
/usr/include/c++/10.1.0/bits/shared_ptr.h:859:14: required from ‘std::shared_ptr<_Tp> std::allocate_shared(const _Alloc&, _Args&& ...) [with _Tp = double; _Alloc = test::dummy_allocator<double, std::allocator<double> >; _Args = {}]’
/home/ray/home/testing/src/alloc.cpp:44:35: required from ‘std::shared_ptr<_Tp> test::allocate_shared(const Alloc&, Args&& ...) [with T = double; Alloc = std::allocator<double>; Args = {}]’
/home/ray/home/testing/src/alloc.cpp:50:36: required from ‘std::shared_ptr<_Tp> test::make_shared(Args&& ...) [with T = double; Args = {}]’
/home/ray/home/testing/src/alloc.cpp:86:46: required from here
/home/ray/home/testing/src/alloc.cpp:25:82: error: no matching function for call to ‘std::allocator<std::_Sp_counted_ptr_inplace<double, test::dummy_allocator<double, std::allocator<double> >, __gnu_cxx::_S_atomic> >::allocator(const test::dummy_allocator<double, std::allocator<double> >&)’
25 | dummy_allocator(Args &&... args) noexcept : alloc(std::forward<Args>(args)...) {}
| ^
In file included from /usr/include/c++/10.1.0/list:61,
from /home/ray/home/testing/src/alloc.cpp:3:
/usr/include/c++/10.1.0/bits/allocator.h:157:2: note: candidate: ‘template<class _Tp1> constexpr std::allocator< <template-parameter-1-1> >::allocator(const std::allocator<_Tp1>&) [with _Tp1 = _Tp1; _Tp = std::_Sp_counted_ptr_inplace<double, test::dummy_allocator<double, std::allocator<double> >, __gnu_cxx::_S_atomic>]’
157 | allocator(const allocator<_Tp1>&) _GLIBCXX_NOTHROW { }
| ^~~~~~~~~
/usr/include/c++/10.1.0/bits/allocator.h:157:2: note: template argument deduction/substitution failed:
/home/ray/home/testing/src/alloc.cpp:25:82: note: ‘const test::dummy_allocator<double, std::allocator<double> >’ is not derived from ‘const std::allocator<_Up>’
25 | dummy_allocator(Args &&... args) noexcept : alloc(std::forward<Args>(args)...) {}
| ^
In file included from /usr/include/c++/10.1.0/list:61,
from /home/ray/home/testing/src/alloc.cpp:3:
/usr/include/c++/10.1.0/bits/allocator.h:147:7: note: candidate: ‘constexpr std::allocator< <template-parameter-1-1> >::allocator(const std::allocator< <template-parameter-1-1> >&) [with _Tp = std::_Sp_counted_ptr_inplace<double, test::dummy_allocator<double, std::allocator<double> >, __gnu_cxx::_S_atomic>]’
147 | allocator(const allocator& __a) _GLIBCXX_NOTHROW
| ^~~~~~~~~
/usr/include/c++/10.1.0/bits/allocator.h:147:34: note: no known conversion for argument 1 from ‘const test::dummy_allocator<double, std::allocator<double> >’ to ‘const std::allocator<std::_Sp_counted_ptr_inplace<double, test::dummy_allocator<double, std::allocator<double> >, __gnu_cxx::_S_atomic> >&’
147 | allocator(const allocator& __a) _GLIBCXX_NOTHROW
| ~~~~~~~~~~~~~~~~~^~~
/usr/include/c++/10.1.0/bits/allocator.h:144:7: note: candidate: ‘constexpr std::allocator< <template-parameter-1-1> >::allocator() [with _Tp = std::_Sp_counted_ptr_inplace<double, test::dummy_allocator<double, std::allocator<double> >, __gnu_cxx::_S_atomic>]’
144 | allocator() _GLIBCXX_NOTHROW { }
| ^~~~~~~~~
/usr/include/c++/10.1.0/bits/allocator.h:144:7: note: candidate expects 0 arguments, 1 provided
... (The above error basically is repeated 2 more times)
In particular, this error seemed representative of the problem occurring:
error: no matching function for call to ‘std::allocator<std::_Sp_counted_ptr_inplace<double, test::dummy_allocator<double, std::allocator<double> >, __gnu_cxx::_S_atomic> >::allocator(const test::dummy_allocator<double, std::allocator<double> >&)’
Where it basically says "in the constructor of dummy_allocator
, you can't pass in a dummy_allocator
to the std::allocator
's constructor". But I'm not doing that. In allocate_shared
, I'm passing in the std::allocator
into the dummy_allocator
.
I've really scratched my head reading the compiler error but came to no conclusions on what I'm doing wrong. Any help would be greatly appreciated!
EDIT: I think I have a hunch that whatever magic shared_ptr is doing underneath, it's trying to do a copy constructor of my dummy_allocator, and perfect forwarding is capturing the copy construction instead an actual copy constructor. However, I have no idea how to solve this as it's a variadic template and I can't use std::is_same<Args, dummy_allocator>
as a requires clause in the perfect forwarding constructor.
Aucun commentaire:
Enregistrer un commentaire